Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial overhaul of python integrated tests for tools. #7788

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

angelosa
Copy link
Member

Initial draft for a simple test pipeline over an handful of selected tools (pngcmp, romcmp, unidasm) as a proof of concept.
Not yet ready for inclusion, needs at very least agreement over:

  1. location of this folder, i.e. sounds more plausible to have it on a different repository than "mamedev/mame".
  2. same deal for assets, I've currently moved it to regtests root, over the fear that they may be useful for other testing facilities.
  3. I've also disabled both chdman and jedutil tests, can't be bothered in making them "pass" given they both tests too much implementation details to my tastes.
  4. Variable/module/folder naming can be better, totally open to suggestions here.
  5. Currently using google style docstrings for functions.
  6. assets expected stdout text files may go boom on checkout if autocrlf is set wrong especially for Windows.

@angelosa angelosa added needs design implementation details needs to be properly addressed tools labels Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs design implementation details needs to be properly addressed tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants