Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Preliminary Nintendo DS sound emulation core #7404

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Implement Preliminary Nintendo DS sound emulation core #7404

wants to merge 3 commits into from

Conversation

cam900
Copy link
Contributor

@cam900 cam900 commented Oct 27, 2020

No description provided.

@MooglyGuy
Copy link
Contributor

Given the Nintendo DS driver does not even boot right now, how was this tested?

cuavas
cuavas reviewed Oct 27, 2020
View reviewed changes
Copy link
Member

@cuavas cuavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to actually exercise this code without requiring the DS driver to get far enough to try playing sound? It seems like a lot of code to write blindly from a specification without test cases.

src/devices/sound/nds_sound.cpp Outdated Show resolved Hide resolved
src/devices/sound/nds_sound.cpp Outdated Show resolved Hide resolved
src/devices/sound/nds_sound.cpp Outdated Show resolved Hide resolved
src/devices/sound/nds_sound.cpp Outdated Show resolved Hide resolved
src/devices/sound/nds_sound.cpp Outdated Show resolved Hide resolved
src/devices/sound/nds_sound.h Outdated Show resolved Hide resolved
@cam900
Copy link
Contributor Author

cam900 commented Oct 27, 2020

Yes, it's can't be testable because the Nintendo DS driver is far from bootable.
This code is based on docs (ex: GBATEK), but Still i can't be verified that's actually working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuavas cuavas cuavas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cam900 @MooglyGuy @cuavas