alpha68k_palette.cpp: Implement Neo Geo palette hardware features, Minor adjust #7239
Conversation
Fix reference color behavior neogeo.cpp: Convert palette handling into alpha68k_palette.cpp
src/mame/video/alpha68k_palette.cpp
Outdated
| if (entry == 0) | ||
| { | ||
| // TODO: actual behaviour, needs HW tests. | ||
| bool is_sync_color = (m_paletteram[offset] & 0x7fff) == 0; |
There was a problem hiding this comment.
This repeats what's in alpha68k_palette_device::update_color, violating DRY.
It is also untested for NeoGeo games (anything really using it?) plus no idea if it really desyncs on bank change if the reference color diverges or it just derive the other bank setting.
src/mame/video/alpha68k_palette.h
Outdated
| std::vector<uint16_t> m_paletteram; | ||
| int m_sync_color_shift[2]; // 2 banks |
There was a problem hiding this comment.
This is not supposed to be initialized as "2 banks" for alpha68k_palette_device
src/mame/video/alpha68k_palette.cpp
Outdated
| update_color(entry, offset); | ||
| } | ||
|
|
||
| inline void neogeo_palette_device::update_color(u16 entry, u16 offset) |
There was a problem hiding this comment.
This is a poor signature:
entrysounds like an alias foroffset, which is not.- is it really necessary to pass
offset, offsetin alpha68k device?
src/mame/video/alpha68k_palette.cpp
Outdated
|
|
||
| inline void neogeo_palette_device::set_color_entry(u16 offset) | ||
| { | ||
| const u16 pal_data = m_paletteram[offset]; |
There was a problem hiding this comment.
I'm not convinced over writing then reading the very same palette data performance-wise, unless you have a profiler output that proves otherwise.
src/mame/video/alpha68k_palette.h
Outdated
| neogeo_palette_device(const machine_config &mconfig, const char *tag, device_t *owner, uint32_t clock); | ||
|
|
||
| // setters | ||
| void set_bank(bool bank) { if (m_bank != bank) { m_bank = bank; m_bankaddr = bank ? m_entries : 0; } } |
There was a problem hiding this comment.
Is this properly refreshing the actual palette data on bank change?
|
btw you haven't fixed "reference color behavior" at all, the actual behaviour is unknown and prolly diverges too between implementations. |
Add configuration for neogeo features, Add notes, Fix initialization neogeo.cpp: Convert palette behavior into alpha68k_palette.cpp
|
Charles MacDonald did observe this behaviour on the NeoGeo, but I think like the CPS stuff where it causes many problems on certain games, it's down to the monitor if it uses it or not. |
Fix initialization, Add notes
neogeo.cpp: Convert palette handling into alpha68k_palette.cpp