mex68kecb: Add Abort button, minor cleanup #12719
Open
+14
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an Abort button that triggers an NMI, just like the hardware. Also fix the boot vector handler's comment to refer to the correct ROM location and the correct number of bytes that are mapped from the ROM.
cuavas
reviewed
Sep 3, 2024
Comment on lines
+110
to
+112
|
|
||
| PORT_START("ABORT") | ||
| PORT_BIT(0x01, IP_ACTIVE_LOW, IPT_BUTTON1) PORT_NAME("Abort button") PORT_CHANGED_MEMBER(DEVICE_SELF, mex68kecb_state, abort_button, 0) |
There was a problem hiding this comment.
Do you want to give this a different default mapping, as I expect Control is used for typing control characters with the terminal? You can use PORT_CODE to set the default assignment.
There was a problem hiding this comment.
Aha, excellent. That’ll be handy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an Abort button that triggers an NMI, just like the hardware.
Also fix the boot vector handler's comment to refer to the correct ROM location and the correct number of bytes that are mapped from the ROM.