Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a NOT WORKING machine (Toy Soldier) #12676

Closed
wants to merge 13 commits into from

Conversation

flama12333
Copy link
Contributor

@flama12333 flama12333 commented Aug 21, 2024

Dumped by Ramclaw
It's a claw machine.
diagram.
https://www.gameroomguys.com/site/pdfs/toysoldier_singlemanual.pdf
uses an aplus API8108A instand voice rom ic which still undumped and unimplemented.
https://www.alldatasheet.com/datasheet-pdf/view/55762/APLUS/API8108A.html
dump will be submitted at email

It's a claw machine
diagram.
https://www.gameroomguys.com/site/pdfs/toysoldier_singlemanual.pdf
has aplus ic which still undumped and unimplemented.
 if gantry inputs is not detected will sound error.


// YEAR NAME PARENT MACHINE INPUT STATE INIT ROT COMPANY FULLNAME FLAGS
GAME( 2003, toysoldier, 0, toysoldier, toysoldier, toysoldier_state, empty_init, ROT0, "Paokai / Coastal Amusements Inc", "Toy Soldier", MACHINE_MECHANICAL | MACHINE_NOT_WORKING | MACHINE_IMPERFECT_SOUND ) // This was dumped from an Coastal branded Toy Soldier from around 2003.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel like the name Toy Soldier to be incredibly generic, can you please add a clarification in the title like Toy Soldier (Coastal Amusements)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be enough to place each separate info in its corresponding field?

The concatenation of both fields would then result in something that is not "incredibly generic".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We’ve got plenty of other systems with “very generic” names (e.g. Ace, After Burner, Silhouette, Albert, Ambush, Anteater, Arabian, Arena, Armada, Arm Wrestling, Attack, Avalanche, Avenger, Barricade, Barrier, and that’s barely past the first letter of the alphabet). We don’t stuff disambiguating text into descriptions unless there’s actually a conflict.

Comment on lines +40 to +43
toysoldier_state(const machine_config &mconfig, device_type type, const char *tag)
: driver_device(mconfig, type, tag)

{ }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don’t leave blank lines between the initialiser list and the constructor body.

src/mame/misc/toysoldier.cpp Outdated Show resolved Hide resolved
Comment on lines 92 to 100
PORT_START("DSW2")
PORT_DIPUNKNOWN_DIPLOC(0x01, 0x01, "SW2:1")
PORT_DIPUNKNOWN_DIPLOC(0x02, 0x02, "SW2:2")
PORT_DIPUNKNOWN_DIPLOC(0x04, 0x04, "SW2:3")
PORT_DIPUNKNOWN_DIPLOC(0x08, 0x08, "SW2:4")
PORT_DIPUNKNOWN_DIPLOC(0x10, 0x10, "SW2:5")
PORT_DIPUNKNOWN_DIPLOC(0x20, 0x20, "SW2:6")
PORT_DIPUNKNOWN_DIPLOC(0x40, 0x40, "SW2:7")
PORT_DIPUNKNOWN_DIPLOC(0x80, 0x80, "SW2:8")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These DIP switches are documented.

Comment on lines 134 to 137
ay8910_device &ay(AY8910(config, "ay", XTAL(12'000'000) / 6)); // Divider not verified
ay.add_route(ALL_OUTPUTS, "mono", 1.0);
ay.port_a_read_callback().set_ioport("DSW1");
ay.port_b_read_callback().set_ioport("DSW2");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s clocked by the ALE output of the 8052 – it will be 1/6 of the 8052 clock frequency, with the issue that data external memory accesses cause it to drop pulses.

Comment on lines 143 to 144
ROM_REGION( 0x10000, "maincpu", 0 )
ROM_LOAD( "toysoldier.bin", 0x00000, 0x10000, CRC(BD52C1AE) SHA1(a76c10f93f9087bc2d01bfe866c0e66a006b4ddd) )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What’s the actual label used for this ROM? Also, use lowercase for hex digits.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will have to ask the owner.

@flama12333
Copy link
Contributor Author

flama12333 commented Sep 27, 2024

I going closed since the owner did not reply me about of rom label. i lost the interest.

@flama12333 flama12333 closed this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants