Switch to JLD2. #414
Switch to JLD2. #414
Conversation
| @@ -18,7 +18,7 @@ Then call the `save` method to save your variables: | |||
| train.save(saver, session, "/path/to/variable_file") | |||
| ``` | |||
|
|
|||
| The newly-created "variable_file" is a [JLD](https://github.com/JuliaIO/JLD.jl) file that contains a mapping from variable names to their values. The value of variables can later be restored in a new Julia session with | |||
| The newly-created "variable_file" is a [JLD2](https://github.com/simonster/JLD2.jl) file that contains a mapping from variable names to their values. The value of variables can later be restored in a new Julia session with | |||
There was a problem hiding this comment.
The variable file is still a JLD file.
It is just being processed and generated with JLD2.
There was a problem hiding this comment.
Oh, can JLD2 load a file saved with JLD1?
There was a problem hiding this comment.
That was my understanding yes.
|
This will be less breaky avoiding #407 and similar |
Codecov Report
@@ Coverage Diff @@
## master #414 +/- ##
==========================================
+ Coverage 63.55% 67.34% +3.79%
==========================================
Files 50 51 +1
Lines 2895 3418 +523
==========================================
+ Hits 1840 2302 +462
- Misses 1055 1116 +61
Continue to review full report at Codecov.
|
|
We should really have a test for this. |
|
Do we want to switch to BSON.jl instead? |
|
Oh ya, why not? It will probably be maintained better going forward, if nothing else. I did a quick check and they same to use the same amount of space for storing our files. |
|
If this passes, lets merge it. |
No description provided.