Define Base.close(::Session)
#342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #342 +/- ##
==========================================
+ Coverage 66.86% 66.93% +0.06%
==========================================
Files 50 50
Lines 2958 2967 +9
==========================================
+ Hits 1978 1986 +8
- Misses 980 981 +1
Continue to review full report at Codecov.
|
oxinabox
reviewed
Oct 24, 2017
src/run.jl
Outdated
| end | ||
|
|
||
| function Base.show(io::IO, err::ClosedSessionError) | ||
| print(io, "Tried to call 'run' with a closed TensorFlow session.") |
There was a problem hiding this comment.
This is assuming the call-stack.
Right now this can only be thrown by run, true.
But the user will find that out by looking at the call-stack.
I think it should be "The TensorFlow session is closed.")
|
Closing sessions is important for freeing the GPU resources. The resources attached to the other TensorFlow objects is pretty trivial. I guess it couldn't hurt to add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.