Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native theme for Win11 & Linux #17

Merged
merged 11 commits into from
Feb 13, 2023
Merged

Native theme for Win11 & Linux #17

merged 11 commits into from
Feb 13, 2023

Conversation

malisipi
Copy link
Owner

No description provided.

@malisipi malisipi marked this pull request as draft February 10, 2023 14:51
@malisipi
Copy link
Owner Author

Note: This pr is draft and will be for awhile.
This pr's purpose is making more native the MUI for Windows (especially 11). The windows and widgets will be use native colors, native APIs, native pop-ups and will be more harmoniousness with Windows.

@malisipi
Copy link
Owner Author

Examples:
image
image

@Wajinn
Copy link

Wajinn commented Feb 10, 2023

One concern that I have about this, though I think it's a fantastic idea and the example looks really good, is when a user makes a cross-platform program for different OSes. They might want a consistent look across the OSes, as oppose to a distinct look for each OS. There can be contrasting and opposing desires from various users.

Hopefully, the selection of themes and APIs for particular OSes would not be so heavy, as to cause issues. Maybe "light themes", might be enough. And when using, from the user perspective, they just select "Windows theme", "macOS theme", "Android theme", etc... Or go with the default or their own custom theme. Of course there are various ways to go about this. Since this is so early phase, just mentioning it as maybe something to think about, from how a user might look at it too. Of course, your view is the most important.

@malisipi
Copy link
Owner Author

MUI's OS themes actually not more than a few native APIs and special config that created before. Cross-platform theme/config is default. If developers wants, native UI settings can be activated. And native settings/components shouldn't broke any cross-platform API. If they do, that brokes the main goal of MUI. So, I mean MUI always focused cross-platform and a cross-platform compability shouldn't will be broken with native APIs. And platform specific-APIs will not public to protect compability.

@malisipi
Copy link
Owner Author

image

MUI works on Linux with Windows 11 dark theme

With the latest commit, native themes can works by across OSs with/without native calls. Native calls if not available the system calls will be replaced with MUI implementations.

@malisipi
Copy link
Owner Author

Linux theme support is on the way. I referenced from Yaru theme colors that used in Ubuntu.

image
image

Also you can see not so different than Windows theme except colors.

@malisipi malisipi changed the title Native theme for windows Native theme for Win11 & Linux Feb 12, 2023
@malisipi malisipi marked this pull request as ready for review February 13, 2023 16:04
@malisipi malisipi merged commit 806e779 into main Feb 13, 2023
@malisipi malisipi mentioned this pull request May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants