Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix argument type passed to db_for_write #222

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Fix argument type passed to db_for_write #222

merged 1 commit into from
Jan 9, 2023

Conversation

LeonidMalin
Copy link
Contributor

As stated in django docs, model argument passed to router.db_for_write method should be model type, not instance. I fixed this issue in related_objects function.

@coveralls
Copy link

Coverage Status

Coverage: 97.122% (+0.01%) from 97.109% when pulling 5b2024b on LeonidMalin:master into 1efb62d on makinacorpus:master.

@coveralls
Copy link

coveralls commented Jan 9, 2023 •
edited
Loading

Coverage Status

Coverage: 97.072% (-0.04%) from 97.109% when pulling 5b2024b on LeonidMalin:master into 1efb62d on makinacorpus:master.

@Gagaro
Copy link
Member

Gagaro commented Jan 9, 2023

Thanks for the PR 👍 .

@Gagaro Gagaro merged commit 4d56fa8 into makinacorpus:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LeonidMalin @coveralls @Gagaro