Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/incorrect-undelete-count #220

Merged

Conversation

segullshairbutt
Copy link
Contributor

It was showing the incorrect number of undelete model objects.
The reason was an old reference to queryset was kept and it was assumed that on applying filter to old queryset will result in old data while in theory it must be 0 if undelete operation was successful.
Following is the outline of changes:

  1. changed count is taken from queryset method instead of counting it again from filter
  2. removed the unused original_quyerset reference

showing incorrect number of undeleted users has been fixed
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 97.109% when pulling 4765f9b on segullshairbutt:bug/incorrect-undelete-count into deb2300 on makinacorpus:master.

@Gagaro
Copy link
Member

Gagaro commented Oct 17, 2022

Thanks for the PR 👍 .

@Gagaro Gagaro merged commit 723e4fe into makinacorpus:master Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants