Skip to content

Commit

Permalink
SB237: Use empty string with empty list for authors, publishers and
Browse files Browse the repository at this point in the history
subjects.
  • Loading branch information
Ai Tran committed Nov 20, 2020
1 parent fef3b21 commit 85e8b54
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions safaribooks.py
Original file line number Diff line number Diff line change
Expand Up @@ -171,9 +171,9 @@ def parse_description(self, desc):
def book_info(self, info):
description = self.parse_description(info["description"]).replace("\n", " ")
for t in [
("Title", info.get("title", "")), ("Authors", ", ".join(aut["name"] for aut in info.get("authors", ""))),
("Title", info.get("title", "")), ("Authors", ", ".join(aut.get("name", "") for aut in info.get("authors", []))),
("Identifier", info.get("identifier", "")), ("ISBN", info.get("isbn", "")),
("Publishers", ", ".join(pub["name"] for pub in info.get("publishers", ""))),
("Publishers", ", ".join(pub.get("name", "") for pub in info.get("publishers", []))),
("Rights", info.get("rights", "")),
("Description", description[:500] + "..." if len(description) >= 500 else description),
("Release Date", info.get("issued", "")),
Expand Down Expand Up @@ -951,16 +951,16 @@ def create_content_opf(self):
escape(aut["name"])
) for aut in self.book_info["authors"])

subjects = "\n".join("<dc:subject>{0}</dc:subject>".format(escape(sub["name"]))
for sub in self.book_info["subjects"])
subjects = "\n".join("<dc:subject>{0}</dc:subject>".format(escape(sub.get("name", "")))
for sub in self.book_info.get("subjects", []))

return self.CONTENT_OPF.format(
(self.book_info.get("isbn", self.book_id)),
escape(self.book_title),
authors,
escape(self.book_info.get("description", "")),
subjects,
", ".join(escape(pub["name"]) for pub in self.book_info.get("publishers", "")),
", ".join(escape(pub.get("name", "")) for pub in self.book_info.get("publishers", [])),
escape(self.book_info.get("rights", "")),
self.book_info.get("issued", ""),
self.cover,
Expand Down

0 comments on commit 85e8b54

Please sign in to comment.