Skip to content

Commit

Permalink
sso_cookies.py: Parse according to RFC 6265
Browse files Browse the repository at this point in the history
Individual cookies in the `Cookie` header, according to Section 5.4 of RFC 6265 [1],
are separated by the "semicolon-space" (`; `) combination. This becomes relevant
when there is a cookie whose value contains a semicolon. I have just encountered one
on O'Reilly Learning, namely `OptanonConsent` ending in `&geolocation=US;CA`,
which was breaking the script.

[1]: https://www.rfc-editor.org/rfc/rfc6265#section-5.4
  • Loading branch information
left-blank committed Jan 20, 2022
1 parent 35d79b2 commit 35bb829
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions sso_cookies.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@

def transform(cookies_string):
cookies = {}
for cookie in cookies_string.split(";"):
cookie = cookie.strip()
for cookie in cookies_string.split("; "):
key, value = cookie.split("=", 1)
cookies[key] = value

Expand Down

0 comments on commit 35bb829

Please sign in to comment.