Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-1820] fix: analytics truncate project name #5089

Merged
merged 5 commits into from
Jul 11, 2024

Conversation

gakshita
Copy link
Collaborator

@gakshita gakshita commented Jul 9, 2024

Truncate project name under custom analytics's project selection dropdown
image

[WEB-1820]

@CLAassistant
Copy link

CLAassistant commented Jul 9, 2024

CLA assistant check
All committers have signed the CLA.

@@ -25,7 +25,7 @@ export const SelectProject: React.FC<Props> = observer((props) => {
content: (
<div className="flex items-center gap-2 truncate">
<span className="text-[0.65rem] text-custom-text-200 flex-shrink-0">{projectDetails?.identifier}</span>
<span className="flex-grow truncate">{projectDetails?.name}</span>
<span className="flex-grow w-[192px] truncate">{projectDetails?.name}</span>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it 192px?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we are using truncate at 3 places. See if we need three, and which of them actually works.

@@ -39,9 +39,9 @@ export const SelectProject: React.FC<Props> = observer((props) => {
label={
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the CustomSearchSelect component, there is an optionsClassName property that applies a custom class name to the dropdown container. We can use this property to address the current issue.

@SatishGandham SatishGandham added this to the v0.23-dev milestone Jul 10, 2024
@gakshita gakshita changed the title Fix/analytics truncate project name [WEB-1820] fix/analytics truncate project name Jul 11, 2024
@gakshita gakshita changed the title [WEB-1820] fix/analytics truncate project name [WEB-1820] fix: analytics truncate project name Jul 11, 2024
@SatishGandham SatishGandham merged commit ac8e588 into preview Jul 11, 2024
13 of 14 checks passed
@SatishGandham SatishGandham deleted the fix/analytics-truncate-project-name branch July 11, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants