events.DeliveryStatus: expose mx-host and additional fields #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jehiah
force-pushed
the
delivery_status_mx_host_311
branch
from
97782a0
to
90ec5e7
Compare
thrawn01
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
events.DeliveryStatusto include additional fields listed in the API docs (and which I observed in practice). I originally noticed thatmx-hostwas missing.Because the boolean fields imply a separate value when they are missing I set them to
*boolbut happy to adjust if there is a style preference. I've marked these new fields as 'omitempty' to indicate they are not always present.https://documentation.mailgun.com/en/latest/api-events.html#event-structure