Adding web_scheme as a primary domain attribute #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@obukhov-sergey @horkhe @dcorn I am unsure who to ping, but I would like to as for a review on this PR, so I can start working on adding this feature to the Mailgun Terraform provider too if all is good. Thank you :) |
thrawn01
approved these changes
Jul 27, 2023
|
Sorry it took a while for me to get to this, thank you so much for this PR! it looks good! |
|
@thrawn01 no problem at the slightest, thank you for the review! |
Szasza
deleted the
feature/301-adding-web-scheme-as-primary-domain-attribute
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #301.
Also removed some unneeded stdout printing from the tag tests.