Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We can set default From in templates, so this should be no longer required when sending templated mails #306

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

paul-conneqtech
Copy link
Contributor

Since we can add headers to templates, those fields should be optional when sending a mail with a template set. The only header that was required was the 'From'.
In this PR the validating of the from field is placed after checking for a set template.

Copy link
Contributor

@thrawn01 thrawn01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

@thrawn01 thrawn01 merged commit ca9d440 into mailgun:master Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants