Skip to content

Commit

Permalink
Minor Updates: Removed unnecesary access modifiers from the service m…
Browse files Browse the repository at this point in the history
…ethod signatures.
  • Loading branch information
mahi-mullapudi committed Sep 7, 2018
1 parent 49fb056 commit 100fb0d
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 18 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public interface AuthenticationService {
* @return
* @throws Exception
*/
public boolean checkEmailIdExists(String emailId) throws Exception;
boolean checkEmailIdExists(String emailId) throws Exception;

/**
* Authenticates the user based on emailId and password entered in the Login page.
Expand All @@ -25,7 +25,7 @@ public interface AuthenticationService {
* @return
* @throws Exception
*/
public boolean authenticatedLogin(String emailId, String password) throws Exception;
boolean authenticatedLogin(String emailId, String password) throws Exception;

/**
* Get Employee details by EmailId.
Expand All @@ -34,5 +34,5 @@ public interface AuthenticationService {
* @return
* @throws Exception
*/
public Employee getEmployeeByEmailId(String emailId) throws Exception;
Employee getEmployeeByEmailId(String emailId) throws Exception;
}
15 changes: 7 additions & 8 deletions src/main/java/com/tutorialq/services/EmailService.java
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
package com.tutorialq.services;

import java.util.List;
import java.util.Map;

import org.springframework.web.multipart.MultipartFile;

import java.util.List;

/**
* Common Mail Service to send mails.
* <b><u>NOTE:</u></b>
Expand All @@ -27,7 +26,7 @@ public interface EmailService {
* @param subject String
* @param mailContent String
*/
public void sendPlainTextMailWithoutAttachment(String fromAddress, String toAddress, String ccAddress, String subject, String mailContent);
void sendPlainTextMailWithoutAttachment(String fromAddress, String toAddress, String ccAddress, String subject, String mailContent);

/**
* Service method to send plain text mail <b>WITH</b> multiple attachments.
Expand All @@ -41,7 +40,7 @@ public interface EmailService {
* For single files add it to list.
* Ex: Arrays.asList(uploadedFile)
*/
public void sendPlainTextMailWithAttachment(String fromAddress, String toAddress, String ccAddress, String subject, String mailContent, List<MultipartFile> attachFiles);
void sendPlainTextMailWithAttachment(String fromAddress, String toAddress, String ccAddress, String subject, String mailContent, List<MultipartFile> attachFiles);

/**
* Service method to send simple plain text mail to multiple recipients
Expand All @@ -53,7 +52,7 @@ public interface EmailService {
* @param subject String
* @param mailContent String of mail content.
*/
public void sendBulkPlainTextMailWithoutAttachment(String fromAddress, List<String> toAddress, List<String> ccAddress, String subject, String mailContent);
void sendBulkPlainTextMailWithoutAttachment(String fromAddress, List<String> toAddress, List<String> ccAddress, String subject, String mailContent);

/**
* Service method to send simple plain text mail to multiple recipients
Expand All @@ -68,7 +67,7 @@ public interface EmailService {
* For single files add it to list.
* Ex: Arrays.asList(uploadedFile)
*/
public void sendBulkPlainTextMailWithAttachment(String fromAddress, List<String> toAddress, List<String> ccAddress, String subject, String mailContent, List<MultipartFile> attachFiles);
void sendBulkPlainTextMailWithAttachment(String fromAddress, List<String> toAddress, List<String> ccAddress, String subject, String mailContent, List<MultipartFile> attachFiles);

/**
* @param fromAddress
Expand All @@ -78,6 +77,6 @@ public interface EmailService {
* @param mailContent
* @throws Exception
*/
public void sendMimeMailWithoutAttachment(String fromAddress, List<String> toAddress, List<String> ccAddress, String subject, String mailContent, boolean isMailHtml) throws Exception;
void sendMimeMailWithoutAttachment(String fromAddress, List<String> toAddress, List<String> ccAddress, String subject, String mailContent, boolean isMailHtml) throws Exception;
}

14 changes: 7 additions & 7 deletions src/main/java/com/tutorialq/services/TimesheetService.java
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public interface TimesheetService {
*
* @param timesheetObj
*/
public void save(Timesheet timesheetObj) throws Exception;
void save(Timesheet timesheetObj) throws Exception;

/**
* Returns the list of Timesheets for a given EmployeeId.
Expand All @@ -22,23 +22,23 @@ public interface TimesheetService {
* @return
* @throws Exception
*/
public List<Timesheet> getTimesheetsByEmpId(long employeeId) throws Exception;
List<Timesheet> getTimesheetsByEmpId(long employeeId) throws Exception;

/**
* Returns the Timesheet information from the Timesheet table based on the given timesheetId.
*
* @param timesheetId
* @return
*/
public Timesheet getTimesheetByTimesheetId(long timesheetId) throws Exception;
Timesheet getTimesheetByTimesheetId(long timesheetId) throws Exception;

/**
* Returns the Timesheet information from the Timesheet table based on the given Timesheet EndDate.
*
* @param endDate
* @return
*/
public Timesheet getTimesheetByEndDate(LocalDate endDate, Employee employee) throws Exception;
Timesheet getTimesheetByEndDate(LocalDate endDate, Employee employee) throws Exception;

/**
* Returns the list of Timesheets for a given From Date, To LocalDate and Timesheet Status.
Expand All @@ -49,7 +49,7 @@ public interface TimesheetService {
* @return
* @throws Exception
*/
public List<Timesheet> getTimesheetSummaryStaff(LocalDate fromDate, LocalDate toDate, String timesheetStatus) throws Exception;
List<Timesheet> getTimesheetSummaryStaff(LocalDate fromDate, LocalDate toDate, String timesheetStatus) throws Exception;

/**
* Approve the Timesheet based on the given TimesheetId and Reviewer Comments.
Expand All @@ -58,7 +58,7 @@ public interface TimesheetService {
* @param timesheetId
* @throws Exception
*/
public void approveTimesheet(long timesheetId, String reviewerName, String reviewerComments) throws Exception;
void approveTimesheet(long timesheetId, String reviewerName, String reviewerComments) throws Exception;

/**
* Reject the Timesheet based on the given TimesheetId and the reviewer comments.
Expand All @@ -67,6 +67,6 @@ public interface TimesheetService {
* @param timesheetId
* @throws Exception
*/
public void rejectTimesheet(long timesheetId, String reviewerName, String reviewerComments) throws Exception;
void rejectTimesheet(long timesheetId, String reviewerName, String reviewerComments) throws Exception;

}

0 comments on commit 100fb0d

Please sign in to comment.