Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Simple products associated with 2 configurables are not exported #200

Closed
boldhedgehog opened this issue Mar 17, 2023 · 1 comment
Assignees
Labels
Investigating We are working on this issue together with the customer.

Comments

@boldhedgehog
Copy link

If simple products are associated with 2 configurable products, and one of them is disabled, simple products are not exported.

Example:
Simple product S is associated with configurable products A (enabled) and B (disabled).

Although, it should be exported to the feed, it is missing.

This is caused by this code:
https://github.com/magmodules/magento2-channable/blob/master/Model/Generate.php#L128

if ($parent = $parents->getItemById($parentId)) {
    continue;
}

The loop first assigns $parent to product A, then assigns it to NULL, because B is not in the parent collection items.

The correct version should be:

if ($parents->getItemById($parentId)) {
    $parent = $parents->getItemById($parentId);
    continue;
}
@Frank-Magmodules Frank-Magmodules self-assigned this Nov 30, 2023
@Frank-Magmodules Frank-Magmodules added the Investigating We are working on this issue together with the customer. label Feb 27, 2024
@Frank-Magmodules Frank-Magmodules changed the title Simple products associated with 2 configurables are not exported [REQUEST] Simple products associated with 2 configurables are not exported Feb 27, 2024
@Frank-Magmodules
Copy link
Member

Hello @boldhedgehog, I'm happy to inform you that your request has been incorporated into our latest release. Thanks for bringing this up. I'll mark this request as closed since I believe we've addressed it to your needs. However, if you have any further questions or comments, please don't hesitate to reopen or add your thoughts to this issue immediately!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Investigating We are working on this issue together with the customer.
Projects
None yet
Development

No branches or pull requests

2 participants