Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix URL constructor bug for Safari #77

Merged
merged 3 commits into from
Apr 28, 2020
Merged

Fix URL constructor bug for Safari #77

merged 3 commits into from
Apr 28, 2020

Conversation

smithki
Copy link
Contributor

@smithki smithki commented Apr 28, 2020

📦 Pull Request

[Provide a general summary of the pull request here.]

🗜 Versioning

(Check one!)

  • Patch: Bug Fix?
  • Minor: New Feature?
  • Major: Breaking Change?

✅ Fixed Issues

⚠️ Update CHANGELOG.md

  • I have updated the Upcoming Changes section of CHANGELOG.md with context related to this Pull Request.

@smithki smithki merged commit 4b5a42c into master Apr 28, 2020
@smithki smithki deleted the fix_url_constructor_CDN_bundle branch April 28, 2020 23:17
@smithki
Copy link
Contributor Author

smithki commented Oct 22, 2020

🚀 PR was released in @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], [email protected] 🚀

@smithki smithki added the released This issue/pull request has been released. label Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

URL Constructor Throws TypeError on Safari Incorrect type signature for RPCProviderModule.enable
1 participant
@smithki