Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: farcaster mobile login #752

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

ysm-dev
Copy link
Collaborator

@ysm-dev ysm-dev commented Jun 21, 2024

πŸ“¦ Pull Request

[Provide a general summary of the pull request here.]

βœ… Fixed Issues

  • [List any fixed issues here like: Fixes #XXXX]

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

Please 🚨 ONLY ADD ONE 🚨 of the following labels, failing to do so may lead to adverse versioning of your changes when published:

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.

Special Note

Please avoid adding any of the Priority labels as they conflict with the labels above ☝️

πŸ“¦ Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @magic-ext/[email protected]
# or 
yarn add @magic-ext/[email protected]

@ysm-dev ysm-dev requested review from octave08 and Ethella June 21, 2024 14:04
@ysm-dev ysm-dev self-assigned this Jun 21, 2024
Copy link
Collaborator

@octave08 octave08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add label correctly

@ysm-dev ysm-dev added the patch Increment the patch version when merged label Jun 21, 2024
@ysm-dev ysm-dev added this pull request to the merge queue Jun 21, 2024
@github-merge-queue github-merge-queue bot merged commit 9349293 into master Jun 21, 2024
6 checks passed
@ysm-dev ysm-dev deleted the chris/farcaster-fix- branch June 21, 2024 14:31
@svc-magic-git
Copy link

πŸš€ PR was released in @magic-ext/[email protected] πŸš€

@svc-magic-git svc-magic-git added the released This issue/pull request has been released. label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants