-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add web3modal extension #742
Open
hcote
wants to merge
53
commits into
master
Choose a base branch
from
hcote-web3modal
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
4df5a5a
add web3modal extension
hcote 0b7d9c7
remove unused vars
hcote a5864bb
rename
hcote 55cc255
move override methods to thirdpartywallet module
hcote a746b06
remove provider dependency
hcote ffbb08d
typing updates
hcote a92e507
fix logout on disconnect
hcote a29c027
add returns to fns routing to tpw methods
hcote c3b302e
Merge branch 'master' into hcote-web3modal
hcote 26604e3
move all logic to thirdpartywallet module
hcote 42a4280
dont route nftCheckout to 3pw
hcote 5a56d1a
update iframe.allow for google login
hcote 3732179
fix capitalization
hcote 56bb93c
add connectWIthUI options param
hcote f262429
make param optional
hcote b9b9caa
add event 1193 event listeners after connecting
hcote 56fde71
update isConnected initialization
hcote 3390b6f
remove old tests
hcote ad6d291
update tests
hcote dac3493
fix deepsource lint errors
hcote 7953979
Merge branch 'master' into hcote-web3modal
hcote 3a83159
update ls key names
hcote d328947
temp: remove reference to ThirdPartyWallets
hcote b44497f
update import
hcote 53124ba
pluralize thirdpartywallets & update to web3modal canary version for …
hcote afa46ff
fix tests
hcote 0386f43
implement nft.checkout with 3rd-party wallets (#744)
octave08 e8f9583
nft checkout update
hcote d862d23
add intermediary events for nft.checkout
hcote baa4f36
Merge branch 'master' into hcote-web3modal
hcote 7ebccbf
Merge branch 'master' into hcote-web3modal
hcote 218e104
yarn.lock
hcote c714eea
update web3modal package
hcote c05cd91
Merge branch 'master' into hcote-web3modal
hcote 884053f
yarn.lock
hcote 39d6e46
update web3modal package
hcote ff13a5f
yarn.lock
hcote 17937db
update web3modal sdk
hcote 3fe30b8
Merge branch 'master' into hcote-web3modal
hcote fb7b0c8
remove unsubscribeFromModalEvents
hcote 911b23e
remove comments
hcote adddb32
add web3modal polyfill
hcote f0a0b3a
pass configOptions directly
hcote bca2cfc
Merge branch 'master' into hcote-web3modal
hcote 9499a53
remove polyfills
hcote 3194efc
update eslint config
hcote 95261f5
update jest coverage
hcote 2b79c30
Merge branch 'master' into hcote-web3modal
hcote e3ecd35
yarn
hcote 561e4f0
yarn.lock
hcote 8b1ae7f
Merge branch 'master' into hcote-web3modal
hcote f68fbea
update localstoragekeys to enum
hcote 6cc7d86
fix: types does not have export yet
hcote File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
pluralize thirdpartywallets & update to web3modal canary version for …
…status
- Loading branch information
commit 53124ba6b4af665bd7cad0e1798ed2cac5d48a0c
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this canary version needed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because
@magic-sdk/types
is a separate package, which is getting updated types that this extension is using, we need@magic-sdk/types
to be published. So I think yes we need to reference a canary version at least at the first publish, then we can update the extension to use a non-canary