Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions #72

Merged
merged 21 commits into from
Apr 29, 2020
Merged

Extensions #72

merged 21 commits into from
Apr 29, 2020

Conversation

smithki
Copy link
Contributor

@smithki smithki commented Apr 24, 2020

πŸ“¦ Pull Request

Provides a base implementation for extensions to Magic APIs

πŸ—œ Versioning

(Check one!)

  • Patch: Bug Fix?
  • Minor: New Feature?
  • Major: Breaking Change?

βœ… Fixed Issues

  • No associated issue

🚨 Test instructions

Run yarn test

⚠️ Update CHANGELOG.md

  • I have updated the Upcoming Changes section of CHANGELOG.md with context related to this Pull Request.

@smithki smithki self-assigned this Apr 24, 2020
@smithki smithki requested a review from harryEth April 24, 2020 00:32
@harryEth
Copy link
Contributor

harryEth commented Apr 29, 2020

https://github.com/MagicHQ/magic-js/blob/80e0aae510a055d7d1d06f4adc241e791014f234/src/types/core/json-rpc-types.ts#L8

Can we change this type to params: any;.

Different blockchains use different params types.

otherwise, lgtm.

@smithki smithki merged commit 4582175 into master Apr 29, 2020
@smithki smithki deleted the feature/extensions branch April 29, 2020 20:30
@smithki
Copy link
Contributor Author

smithki commented Oct 22, 2020

@smithki smithki added the released This issue/pull request has been released. label Oct 22, 2020
@smithki
Copy link
Contributor Author

smithki commented Oct 22, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants