Add ability to use server callback url for start of oauth2 flow #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -44,7 +44,10 @@ export class OAuthExtension extends Extension.Internal<'oauth2'> { | |||
| } | |||
|
|
|||
| if (successResult?.oauthAuthoriationURI) { | |||
| window.location.href = successResult.oauthAuthoriationURI; | |||
| window.location.href = successResult.useMagicServerCallback | |||
| ? // @ts-ignore - this.sdk.endpoint is marked protected but we need to access it. | |||
There was a problem hiding this comment.
how about adding a public getter function for endpoint so we don't have to do this?
There was a problem hiding this comment.
Yeah, I was thinking the same thing since this is protected. Didn't want to muddy up this PR so perhaps we can make a separate PR for this?
Ethella
previously approved these changes
Feb 27, 2024
Ethella
approved these changes
Feb 27, 2024
romin-halltari
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Pull Request
[Provide a general summary of the pull request here.]
✅ Fixed Issues
🚨 Test instructions
[Describe any additional context required to test the PR/feature/bug fix.]
Please only add one label:
patch: Bug Fix?minor: New Feature?major: Breaking Change?skip-release: It's unnecessary to publish this change.📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via: