Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn developers of Coming Deprecation of Universal Wallet API Keys #713

Closed

Conversation

Ariflo
Copy link
Contributor

@Ariflo Ariflo commented Feb 21, 2024

πŸ“¦ Pull Request

Adds warning to Universal Wallet API Key app developers of impending doom 😈 of Universal Wallet API Keys. We check for product_type to be returned via postMessage after the initial call to /config when we retrieve the theme.

When utilizing a UW API Keys the warning will appear as follows for magic-sdk and all react-native SDK apps:

WARN  Magic SDK Warning: [DEPRECATION_NOTICE] `Usage of Universal Wallet API Keys` will be removed from `@magic-sdk/react-native-bare` in version `v22.0.0`. Use `Dedicated Wallet API Key` instead to prevent disruption of the wallet service.

βœ… Fixed Issues

N/A

🚨 Test instructions

Run https://github.com/magiclabs/react-native-demo app locally and follow the instructions set here to test.

Reviewer Notes (Optional)

This PR will work in tandem with https://github.com/magiclabs/phantom/pull/3360

⚠️ Don't forget to add a semver label!

Please only add one label:

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.
πŸ“¦ Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install [email protected]
# or 
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add [email protected]

@Ariflo Ariflo added the minor Increment the minor version when merged label Feb 21, 2024
@Ariflo Ariflo self-assigned this Feb 21, 2024
@Ariflo Ariflo force-pushed the ariflo-PDEEXP-237-warn-universal-wallet-devs-of-doom branch from ddd60ad to cf8acd3 Compare February 23, 2024 01:19
@Ariflo Ariflo marked this pull request as draft February 23, 2024 02:42
@Ariflo Ariflo force-pushed the ariflo-PDEEXP-237-warn-universal-wallet-devs-of-doom branch 2 times, most recently from 90a5f1e to 4b3668c Compare February 23, 2024 03:32
@Ariflo Ariflo force-pushed the ariflo-PDEEXP-237-warn-universal-wallet-devs-of-doom branch from 4b3668c to 384b599 Compare February 23, 2024 19:40
@Ariflo Ariflo closed this Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant