Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New OAuth 2 ext package #710

Merged
merged 6 commits into from
Feb 21, 2024
Merged

New OAuth 2 ext package #710

merged 6 commits into from
Feb 21, 2024

Conversation

patjacobs-magic
Copy link
Contributor

@patjacobs-magic patjacobs-magic commented Feb 13, 2024

πŸ“¦ Pull Request

This creates a new ext package oauth2. This will execute Magic's new oauth v2 flow with improved performance and stability.

βœ… Fixed Issues

🚨 Test instructions

⚠️ Don't forget to add a semver label!

Please only add one label:

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.
πŸ“¦ Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @magic-ext/[email protected]
# or 
yarn add @magic-ext/[email protected]

@patjacobs-magic patjacobs-magic added the prerelease This change is available in a prerelease. label Feb 13, 2024
@patjacobs-magic patjacobs-magic self-assigned this Feb 13, 2024
@patjacobs-magic patjacobs-magic added the minor Increment the minor version when merged label Feb 13, 2024
@patjacobs-magic patjacobs-magic marked this pull request as ready for review February 13, 2024 01:12
@patjacobs-magic patjacobs-magic added major Increment the major version when merged and removed minor Increment the minor version when merged labels Feb 13, 2024
@Ethella
Copy link
Member

Ethella commented Feb 15, 2024

One NIT, otherwise looks good to me. This could be a patch release, as it's the very first release

@patjacobs-magic patjacobs-magic added patch Increment the patch version when merged and removed major Increment the major version when merged labels Feb 15, 2024
@patjacobs-magic patjacobs-magic added this pull request to the merge queue Feb 21, 2024
Merged via the queue into master with commit e960512 Feb 21, 2024
4 checks passed
@patjacobs-magic patjacobs-magic deleted the patjacobs-PDEEXP-8-oauth2 branch February 21, 2024 00:40
@Ariflo Ariflo added released This issue/pull request has been released. and removed prerelease This change is available in a prerelease. labels Feb 22, 2024
@magiclabs magiclabs deleted a comment from Ariflo Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants