Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove auth extension #682

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Remove auth extension #682

merged 2 commits into from
Dec 8, 2023

Conversation

Ethella
Copy link
Member

@Ethella Ethella commented Dec 5, 2023

πŸ“¦ Pull Request

Per approval from the PM, we're deprecating the magic-auth extension. And keep using the core sdk for the auth function

βœ… Fixed Issues

  • [List any fixed issues here like: Fixes #XXXX]

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

Please only add one label:

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.

@Ethella Ethella added the skip-release Preserve the current version when merged label Dec 5, 2023
@Ethella Ethella requested a review from Ariflo December 5, 2023 19:32
@Ethella Ethella self-assigned this Dec 5, 2023
Ariflo
Ariflo previously approved these changes Dec 5, 2023
Copy link
Contributor

@Ariflo Ariflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘‹

@Ethella Ethella added this pull request to the merge queue Dec 8, 2023
Merged via the queue into master with commit 7bc54cc Dec 8, 2023
4 checks passed
@Ethella Ethella deleted the deprecating-magic-auth branch December 8, 2023 18:17
@Ariflo Ariflo added the released This issue/pull request has been released. label Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released. skip-release Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants