Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split key device share #678

Merged
merged 27 commits into from
Dec 14, 2023
Merged

Split key device share #678

merged 27 commits into from
Dec 14, 2023

Conversation

Dizigen
Copy link
Contributor

@Dizigen Dizigen commented Nov 30, 2023

📦 Pull Request

Implements the "Device Share Recovery" flow of our Split Key implementation of the Magic Delegated Key Management System.

The SDK will now cache a web-crypto encrypted version of the Client Share key that has been encrypted with the Magic KMS.

Storing this share user side will allow the DKMS to cut out a call to the client KMS, as the share will be cached device side and decrypt-able with the Magic KMS.

The device share will be encrypted with web crypto generated "AES-GCM" encryption key along with an initialization vector, both of which will be stored to the indexedDB of the client frame as well.

✅ Fixed Issues

SC Tickets

🚨 Test instructions

Talk to our sales department.

⚠️ Don't forget to add a semver label!

Please only add one label:

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install [email protected]
# or 
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add [email protected]

@Dizigen Dizigen added the patch Increment the patch version when merged label Nov 30, 2023
@Dizigen Dizigen self-assigned this Nov 30, 2023
@Dizigen Dizigen marked this pull request as ready for review December 6, 2023 20:39
@Dizigen Dizigen added minor Increment the minor version when merged and removed patch Increment the patch version when merged labels Dec 6, 2023
@Dizigen Dizigen added this pull request to the merge queue Dec 14, 2023
Merged via the queue into master with commit 82f1080 Dec 14, 2023
4 checks passed
@Dizigen Dizigen deleted the split-key-device-share branch December 14, 2023 22:04
@Ariflo Ariflo added the released This issue/pull request has been released. label Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants