Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: increase netinfo version range #677

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Fix: increase netinfo version range #677

merged 2 commits into from
Nov 29, 2023

Conversation

romin-halltari
Copy link
Contributor

@romin-halltari romin-halltari commented Nov 29, 2023 •
edited by github-actions bot
Loading

📦 Pull Request

[Provide a general summary of the pull request here.]
Increase netinfo version range to allow projects to use versions that Expo requires.

✅ Fixed Issues

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

Please only add one label:

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
# or 
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]

@romin-halltari romin-halltari added the patch Increment the patch version when merged label Nov 29, 2023
@romin-halltari romin-halltari self-assigned this Nov 29, 2023
@romin-halltari romin-halltari changed the title Fix/increase netinfo version range Fix: increase netinfo version range Nov 29, 2023
Ariflo
Ariflo approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@Ariflo Ariflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romin-halltari romin-halltari added this pull request to the merge queue Nov 29, 2023
Merged via the queue into master with commit ede9421 Nov 29, 2023
4 checks passed
@romin-halltari romin-halltari deleted the fix/increase-netinfo-version-range branch November 29, 2023 18:25
@Ariflo
Copy link
Contributor

Ariflo commented Nov 29, 2023

🚀 PR was released in @magic-ext/[email protected], @magic-ext/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected] 🚀

@Ariflo Ariflo added the released This issue/pull request has been released. label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ariflo Ariflo Ariflo approved these changes

Assignees

@romin-halltari romin-halltari

Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dependency Conflict with netinfo with latest Expo version
2 participants
@romin-halltari @Ariflo