Fix: Allow implementers of view-controller
to set if it's connected to the internet, and reject requests when isConnectedToInternet
is false
#673
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Pull Request
Fix: Allow classes that extend
view-controller
to set if it's connected to the internet, and reject requests whenisConnectedToInternet
isfalse
.On mobile, it takes a while for the connectivity to the overlay to be established. If a method like
isLoggedIn
is called before that (i.e. on app start-up), it would reject it, which is not ideal. This fix allows you to call methods likeisLoggedIn
even before the connection is established, and wait for a response.✅ Fixed Issues
Fixes MagicSDK stopped working since yesterday: MODAL_NOT_READY or network timeout #672
🚨 Test instructions
[Describe any additional context required to test the PR/feature/bug fix.]
Please only add one label:
patch
: Bug Fix?minor
: New Feature?major
: Breaking Change?skip-release
: It's unnecessary to publish this change.📦 Published PR as canary version:
Canary Versions
✨ Test out this PR locally via: