Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Rename: ready -> checkIsReadyForRequest and isReady -> isReadyForRequest" #668

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Revert "Rename: ready -> checkIsReadyForRequest and isReady -> isReadyForRequest" #668

merged 2 commits into from
Nov 21, 2023

Conversation

romin-halltari
Copy link
Contributor

@romin-halltari romin-halltari commented Nov 21, 2023 •
edited by github-actions bot
Loading

This reverts commit 09ec393

📦 Pull Request

[Provide a general summary of the pull request here.]

✅ Fixed Issues

  • [List any fixed issues here like: Fixes #XXXX]

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

Please only add one label:

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
# or 
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]

@romin-halltari romin-halltari added the major Increment the major version when merged label Nov 21, 2023
@romin-halltari romin-halltari self-assigned this Nov 21, 2023
@shortcut-integration Shortcut Integration
Copy link

This pull request has been linked to Shortcut Story #90767: Deprecate v17 of @magic-ext/react-native-bare-oauth and @magic-ext/react-native-expo-oauth and revert name changes to loginWithPopup.

@romin-halltari romin-halltari added this pull request to the merge queue Nov 21, 2023
Merged via the queue into master with commit d342325 Nov 21, 2023
4 checks passed
@romin-halltari romin-halltari deleted the rominhalltari-sc-90767-deprecate-v17-of-magic-ext-react-native-bare branch November 21, 2023 17:02
@Ariflo
Copy link
Contributor

Ariflo commented Nov 21, 2023

🚀 PR was released in @magic-ext/[email protected], @magic-ext/[email protected] 🚀

@Ariflo Ariflo added the released This issue/pull request has been released. label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ethella Ethella Ethella approved these changes

@Ariflo Ariflo Awaiting requested review from Ariflo

Assignees

@romin-halltari romin-halltari

Labels
major Increment the major version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@romin-halltari @Ariflo @Ethella