Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types to sign methods to avoid returning 'any' type #662

Merged

Conversation

octave08
Copy link
Collaborator

@octave08 octave08 commented Nov 9, 2023

πŸ“¦ Pull Request

[Provide a general summary of the pull request here.]

Add types to sign methods to avoid returning 'any' type

βœ… Fixed Issues

  • [List any fixed issues here like: Fixes #XXXX]

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

Please only add one label:

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.
πŸ“¦ Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @magic-ext/[email protected]
# or 
yarn add @magic-ext/[email protected]

@octave08 octave08 added the patch Increment the patch version when merged label Nov 9, 2023
@octave08 octave08 requested a review from karljin November 9, 2023 05:24
@octave08 octave08 self-assigned this Nov 9, 2023
Copy link

Copy link

Copy link

@octave08 octave08 added skip-release Preserve the current version when merged and removed patch Increment the patch version when merged labels Nov 9, 2023
@octave08 octave08 added this pull request to the merge queue Nov 9, 2023
Merged via the queue into master with commit 21233b7 Nov 9, 2023
4 checks passed
@octave08 octave08 deleted the jayhwang-sc-90219-signature-verification-error-solana-nova branch November 9, 2023 22:24
@Ariflo
Copy link
Contributor

Ariflo commented Nov 13, 2023

@Ariflo Ariflo added the released This issue/pull request has been released. label Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released. skip-release Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants