Adds optional backgroundColor prop to Relayer component #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #70361: [React Native SDKs] React Native SafeAreaView causes modal to show background. |
…afeAreaView showing background because it is transparent.
romin-halltari
force-pushed
the
rominhalltari-sc-70361-react-native-sdks-react-native-safeareaview
branch
from
e922ede
to
e1fbb8c
Compare
…eact-native-safeareaview
romin-halltari
deleted the
rominhalltari-sc-70361-react-native-sdks-react-native-safeareaview
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Pull Request
[Provide a general summary of the pull request here.]
Fix: Add optional backgroundColor prop to relayer to fix issue with SafeAreaView showing background because it is transparent. Check before/after recordings below.
✅ Fixed Issues
React Native SafeAreaView causes modal to show background #445
🚨 Test instructions
[Describe any additional context required to test the PR/feature/bug fix.]
Please only add one label:
patch: Bug Fix?minor: New Feature?major: Breaking Change?skip-release: It's unnecessary to publish this change.After.mov
Before.mov
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via: