Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn developers of Coming Deprecation of Universal Wallet API Keys #632

Closed
wants to merge 8 commits into from

Conversation

Ariflo
Copy link
Contributor

@Ariflo Ariflo commented Sep 21, 2023

πŸ“¦ Pull Request

Adds warning to Universal Wallet API Key app developers of impending doom 😈 of Universal Wallet API Keys. We check for product_type to be returned via postMessage after the initial call to /config when we retrieve the theme.

When utilizing a UW API Keys the warning will appear as follows for magic-sdk and all react-native SDK apps:

WARN  Magic SDK Warning: [DEPRECATION_NOTICE] `Usage of Universal Wallet API Keys` will be removed from `@magic-sdk/react-native-bare` in version `v22.0.0`. Use `Dedicated Wallet API Key` instead to prevent disruption of the wallet service.

βœ… Fixed Issues

N/A

🚨 Test instructions

Run https://github.com/magiclabs/react-native-demo app locally and follow the instructions set here to test.

Reviewer Notes (Optional)

This PR will work in tandem with https://github.com/magiclabs/phantom/pull/3037

⚠️ Don't forget to add a semver label!

Please only add one label:

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.
πŸ“¦ Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install [email protected]
# or 
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add [email protected]

@Ariflo Ariflo added the minor Increment the minor version when merged label Sep 21, 2023
@Ariflo Ariflo self-assigned this Sep 21, 2023
@shortcut-integration
Copy link

@Ariflo Ariflo force-pushed the ariflo-sc-87491-warn-dev-of-universal-doom branch from 1b059cc to 90f1b1e Compare September 21, 2023 21:45
@Ariflo Ariflo force-pushed the ariflo-sc-87491-warn-dev-of-universal-doom branch from dc19c87 to 03c9740 Compare September 21, 2023 23:30
@Ariflo Ariflo force-pushed the ariflo-sc-87491-warn-dev-of-universal-doom branch from 03c9740 to 851922e Compare September 21, 2023 23:51
@Ariflo
Copy link
Contributor Author

Ariflo commented Oct 11, 2023

Blocked / on-hold until December announcement.

@Ariflo Ariflo closed this Oct 11, 2023
auto-merge was automatically disabled October 11, 2023 17:08

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant