Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polyfill certain globals for React Native #63

Merged
merged 3 commits into from
Apr 23, 2020
Merged

Polyfill certain globals for React Native #63

merged 3 commits into from
Apr 23, 2020
+29 −1

Conversation

smithki
Copy link
Contributor

@smithki smithki commented Apr 23, 2020

📦 Pull Request

polyfills missing globals for React Native environments.

🗜 Versioning

(Check one!)

  • Patch: Bug Fix?
  • Minor: New Feature?
  • Major: Breaking Change?

✅ Fixed Issues

🚨 Test instructions

None.

⚠️ Update CHANGELOG.md

  • I have updated the Upcoming Changes section of CHANGELOG.md with context related to this Pull Request.

@smithki smithki requested a review from Ethella April 23, 2020 00:14
@smithki smithki self-assigned this Apr 23, 2020
@smithki smithki merged commit e336072 into master Apr 23, 2020
@smithki smithki deleted the bug/rn_polyfills branch April 23, 2020 02:22
@smithki
Copy link
Contributor Author

smithki commented Oct 22, 2020

🚀 PR was released in @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], [email protected] 🚀

@smithki smithki added the released This issue/pull request has been released. label Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dizigen Dizigen Dizigen approved these changes

@Ethella Ethella Awaiting requested review from Ethella

Assignees

@smithki smithki

Labels
released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Certain globals need polyfilling for React Native
2 participants
@smithki @Dizigen