Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables WebView Inspection for RN SDKs #587

Merged
merged 3 commits into from
Jul 21, 2023

Conversation

Ariflo
Copy link
Contributor

@Ariflo Ariflo commented Jul 20, 2023

πŸ“¦ Pull Request

Enables WebView Inspection for RN SDKs released in version 12.4 of the library: react-native-webview/react-native-webview#2937

βœ… Fixed Issues

n/a

🚨 Test instructions

n/a

⚠️ Don't forget to add a semver label!

Please only add one label:

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.
πŸ“¦ Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
# or 
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]

@Ariflo Ariflo added the patch Increment the patch version when merged label Jul 20, 2023
@Ariflo Ariflo requested a review from Ethella July 20, 2023 18:42
@Ariflo Ariflo self-assigned this Jul 20, 2023
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #82003: Enable WebView Inspections for RN SDKs.

@Ariflo Ariflo force-pushed the ariflo-sc-82003-enable-webview-inspection branch from 015954d to ec14b23 Compare July 20, 2023 18:43
@Ariflo Ariflo enabled auto-merge July 20, 2023 18:43
Ethella
Ethella previously approved these changes Jul 20, 2023
@Ariflo Ariflo force-pushed the ariflo-sc-82003-enable-webview-inspection branch 4 times, most recently from 34eb301 to ec14b23 Compare July 20, 2023 19:41
Ethella
Ethella previously approved these changes Jul 20, 2023
@Ariflo Ariflo added this pull request to the merge queue Jul 20, 2023
@Ariflo Ariflo force-pushed the ariflo-sc-82003-enable-webview-inspection branch from 94f1751 to 869b810 Compare July 20, 2023 20:37
@Ariflo Ariflo removed this pull request from the merge queue due to a manual request Jul 20, 2023
@Ariflo Ariflo enabled auto-merge July 20, 2023 20:43
@Ariflo Ariflo force-pushed the ariflo-sc-82003-enable-webview-inspection branch 5 times, most recently from 462563f to 77c491c Compare July 21, 2023 17:31
@Ariflo Ariflo force-pushed the ariflo-sc-82003-enable-webview-inspection branch from 77c491c to 53eaaae Compare July 21, 2023 20:01
@Ariflo Ariflo added this pull request to the merge queue Jul 21, 2023
Merged via the queue into master with commit 1f0d895 Jul 21, 2023
4 checks passed
@Ariflo Ariflo deleted the ariflo-sc-82003-enable-webview-inspection branch July 21, 2023 20:23
@Ariflo Ariflo added the released This issue/pull request has been released. label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants