Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace magic-sdk w/ @magic-sdk/commons for @magic-ext/oidc Package #550

Merged
merged 7 commits into from
Jun 23, 2023
Merged

Replace magic-sdk w/ @magic-sdk/commons for @magic-ext/oidc Package #550

merged 7 commits into from
Jun 23, 2023

Conversation

Ariflo
Copy link
Contributor

@Ariflo Ariflo commented Jun 22, 2023 •
edited by magiclabsFE
Loading

📦 Pull Request

Replace magic-sdk w/ @magic-sdk/commons for @magic-ext/oidc for React Native compatibility.

✅ Fixed Issues

  • N/A

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

Please only add one label:

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install [email protected]
# or 
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add [email protected]

@Ariflo Ariflo added the minor Increment the minor version when merged label Jun 22, 2023
@Ariflo Ariflo self-assigned this Jun 22, 2023
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #80003: Nova Labs - OIDC with React Native Bare Issue.

@Ariflo Ariflo temporarily deployed to production June 22, 2023 19:54 — with GitHub Actions Inactive
@Ariflo Ariflo temporarily deployed to production June 22, 2023 20:00 — with GitHub Actions Inactive
joshuascan
joshuascan previously approved these changes Jun 22, 2023
View reviewed changes
@Ariflo Ariflo changed the title Add React Native Specific OIDC Packages Replace magic-sdk w/ @magic-sdk/commons for @magic-ext/oidc Package Jun 22, 2023
@Ariflo Ariflo added patch Increment the patch version when merged and removed minor Increment the minor version when merged labels Jun 22, 2023
@Ariflo Ariflo temporarily deployed to production June 22, 2023 22:15 — with GitHub Actions Inactive
@Ariflo Ariflo force-pushed the ariflo-sc-80003-new-rn-specific-oidc branch from 8fc4d1c to 1a08473 Compare June 23, 2023 00:13
@Ariflo Ariflo force-pushed the ariflo-sc-80003-new-rn-specific-oidc branch from 1a08473 to 050c571 Compare June 23, 2023 19:36
@Ariflo Ariflo temporarily deployed to production June 23, 2023 19:41 — with GitHub Actions Inactive
@Ariflo Ariflo merged commit 02a5fa5 into master Jun 23, 2023
@Ariflo Ariflo deleted the ariflo-sc-80003-new-rn-specific-oidc branch June 23, 2023 21:40
@magiclabsFE
Copy link

🚀 PR was released in @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], [email protected] 🚀

@magiclabsFE magiclabsFE added the released This issue/pull request has been released. label Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ethella Ethella Ethella approved these changes

@joshuascan joshuascan joshuascan left review comments

Assignees

@Ariflo Ariflo

Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ariflo @magiclabsFE @Ethella @joshuascan