Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove approval step for canary releases [sc-80045] #549

Merged
merged 3 commits into from
Jun 23, 2023
Merged

Remove approval step for canary releases [sc-80045] #549

merged 3 commits into from
Jun 23, 2023

Conversation

bcleary06
Copy link
Contributor

@bcleary06 bcleary06 commented Jun 22, 2023 •
edited by magiclabsFE
Loading

📦 Pull Request

Remove approval step for canary releases

✅ Fixed Issues

  • Fixes #80045

🚨 Test instructions

Validate canary release on next merge to master is auto published

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install [email protected]
# or 
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add [email protected]

@bcleary06 bcleary06 added the patch Increment the patch version when merged label Jun 22, 2023
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #80045: Remove approval step for canary releases.

Dizigen
Dizigen previously approved these changes Jun 22, 2023
View reviewed changes
makrandgupta
makrandgupta previously approved these changes Jun 22, 2023
View reviewed changes
Ariflo
Ariflo previously approved these changes Jun 22, 2023
View reviewed changes
@bcleary06 bcleary06 dismissed stale reviews from Ariflo, makrandgupta, and Dizigen via 77fc1f5 June 22, 2023 18:41
@bcleary06 bcleary06 merged commit 15d2804 into master Jun 23, 2023
4 checks passed
@bcleary06 bcleary06 deleted the briancleary7114-sc-80045-remove-approval-step-for-canary-releases branch June 23, 2023 19:59
@magiclabsFE
Copy link

🚀 PR was released in @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], [email protected] 🚀

@magiclabsFE magiclabsFE added the released This issue/pull request has been released. label Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ariflo Ariflo Ariflo approved these changes

@Dizigen Dizigen Dizigen left review comments

@makrandgupta makrandgupta makrandgupta left review comments

@bengriffin1 bengriffin1 Awaiting requested review from bengriffin1

@Ethella Ethella Awaiting requested review from Ethella

@hcote hcote Awaiting requested review from hcote

Assignees
No one assigned
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bcleary06 @magiclabsFE @Dizigen @makrandgupta @Ariflo