Implement MagicAptosWallet #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #78656: [aptos] implement MagicAptosWallet. |
3a4af64
to
9ddc5c3
Compare
87149ef
to
b4b9ec8
Compare
b4b9ec8
to
dc59435
Compare
6636206
to
1014638
Compare
karljin
reviewed
May 30, 2023
| readonly url = 'https://magic.link/'; | ||
| readonly icon = ICON_BASE64; | ||
|
|
||
| readonly providerName = 'magicWallet'; |
There was a problem hiding this comment.
can we change this to "magicWalletMA" (just in case we have to do something else for MC later)
There was a problem hiding this comment.
Nice catch.
fixed it a35b6b1
karljin
reviewed
May 30, 2023
| provider: Magic<[AptosExtension]>; | ||
| private accountInfo: AccountInfo | null; | ||
|
|
||
| constructor(magic: Magic<[AptosExtension]>) { |
There was a problem hiding this comment.
i think email should be passed in here, instead of us creating a different "connectWithMagicLink" function
There was a problem hiding this comment.
sounds good :)
fixed it. a35b6b1
karljin
previously approved these changes
May 30, 2023
karljin
approved these changes
May 31, 2023
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Pull Request
[Provide a general summary of the pull request here.]
✅ Fixed Issues
https://app.shortcut.com/magic-labs/story/78656/aptos-implement-magicaptoswallet
https://app.shortcut.com/magic-labs/story/78763/aptos-add-support-for-react-adapter-react
🚨 Test instructions
[Describe any additional context required to test the PR/feature/bug fix.]
Please only add one label:
patch: Bug Fix?minor: New Feature?major: Breaking Change?skip-release: It's unnecessary to publish this change.