Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conditional for useInstead of loginWithMagicLink createDeprecationWarning call #518

Merged
merged 2 commits into from
May 18, 2023
Merged

Add conditional for useInstead of loginWithMagicLink createDeprecationWarning call #518

merged 2 commits into from
May 18, 2023

Conversation

Ariflo
Copy link
Contributor

@Ariflo Ariflo commented May 18, 2023 •
edited by magiclabsFE
Loading

📦 Pull Request

Adds a isRNMobilePackage variable to encourage RN package users to use auth.loginWithEmailOTP() instead of the @magic-ext/auth auth.loginWithMagicLink() as they will be unable to do so on the next major release.

✅ Fixed Issues

n/a

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

Please only add one label:

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install [email protected]
# or 
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add [email protected]

@Ariflo Ariflo added the patch Increment the patch version when merged label May 18, 2023
@Ariflo Ariflo requested review from Dizigen and Ethella May 18, 2023 18:30
@Ariflo Ariflo self-assigned this May 18, 2023
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #78088: Add Separate Deprecation of LoginWithMagicLink Warning for RN Packages.

Dizigen
Dizigen previously approved these changes May 18, 2023
View reviewed changes
@Ariflo Ariflo force-pushed the ariflo-sc-78088-update-deprecation-warning branch from bf66ef2 to 6fb0e0b Compare May 18, 2023 20:41
@Ariflo Ariflo temporarily deployed to production May 18, 2023 20:47 — with GitHub Actions Inactive
@Ariflo Ariflo merged commit 28e9281 into master May 18, 2023
4 checks passed
@Ariflo Ariflo deleted the ariflo-sc-78088-update-deprecation-warning branch May 18, 2023 21:05
@magiclabsFE
Copy link

🚀 PR was released in @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], [email protected] 🚀

@magiclabsFE magiclabsFE added the released This issue/pull request has been released. label May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dizigen Dizigen Dizigen approved these changes

@Ethella Ethella Awaiting requested review from Ethella

Assignees

@Ariflo Ariflo

Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ariflo @magiclabsFE @Dizigen