Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes Magic link Method #516

Merged
merged 7 commits into from
Jun 20, 2023
Merged

Removes Magic link Method #516

merged 7 commits into from
Jun 20, 2023

Conversation

Ariflo
Copy link
Contributor

@Ariflo Ariflo commented May 18, 2023 •
edited by magiclabsFE
Loading

📦 Pull Request

To be released June 20th

✅ Fixed Issues

n/a

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

Please only add one label:

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install [email protected]
# or 
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add [email protected]

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #73888: Remove LoginWithMagicLink - Both RN Packages (Bare + Expo) SDK.

@Ariflo Ariflo marked this pull request as draft May 18, 2023 00:04
@Ariflo Ariflo self-assigned this May 18, 2023
@Ariflo Ariflo added the major Increment the major version when merged label May 18, 2023
@Ariflo Ariflo changed the title [DO NOT MERGE] Removes Magic link Method Removes Magic link Method Jun 15, 2023
@Ariflo Ariflo force-pushed the ariflo-sc-73888-remove-magic-link branch from f57d97a to e3cedce Compare June 20, 2023 16:16
@Ariflo Ariflo requested a review from Ethella June 20, 2023 16:17
@Ariflo Ariflo marked this pull request as ready for review June 20, 2023 16:18
@Ariflo Ariflo force-pushed the ariflo-sc-73888-remove-magic-link branch from e3cedce to 57d9527 Compare June 20, 2023 16:50
@Ariflo Ariflo force-pushed the ariflo-sc-73888-remove-magic-link branch from 57d9527 to 2757f08 Compare June 20, 2023 16:53
@Ariflo Ariflo requested a review from makrandgupta June 20, 2023 18:26
@Ariflo Ariflo temporarily deployed to production June 20, 2023 18:32 — with GitHub Actions Inactive
@Ariflo Ariflo merged commit 62fe2b8 into master Jun 20, 2023
3 of 4 checks passed
@Ariflo Ariflo deleted the ariflo-sc-73888-remove-magic-link branch June 20, 2023 22:30
@magiclabsFE
Copy link

🚀 PR was released in @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], [email protected] 🚀

@magiclabsFE magiclabsFE added the released This issue/pull request has been released. label Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ethella Ethella Ethella approved these changes

@makrandgupta makrandgupta Awaiting requested review from makrandgupta

Assignees

@Ariflo Ariflo

Labels
major Increment the major version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ariflo @magiclabsFE @Ethella