React Native Expo SDK WebView Url Tap Navigate to Device Browser when open_in_device_browser is True
#508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #77239: Update React Native Expo SDK WebView to navigate to Mobile Browser Context. |
Ethella
approved these changes
May 9, 2023
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Pull Request
Utilizes
react-native-webview'sonShouldStartLoadWithRequestto detect if a url containsopen_in_device_browserquery and determine if link should be opened on device browser app.✅ Fixed Issues
N/A
🚨 Test instructions
Tested the following flow against https://github.com/fortmatic/phantom/pull/2489 update to Relayer with our React Native Demo Apps on iOS and Android.
Android
iOS
Please only add one label:
patch: Bug Fix?minor: New Feature?major: Breaking Change?skip-release: It's unnecessary to publish this change.📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via: