Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add boilerplate code #5

Merged
merged 22 commits into from
Feb 24, 2020
Merged

Add boilerplate code #5

merged 22 commits into from
Feb 24, 2020

Conversation

smithki
Copy link
Contributor

@smithki smithki commented Feb 21, 2020 •
edited
Loading

Fixes #4
Fixes #6
Fixes #9

@smithki smithki marked this pull request as ready for review February 22, 2020 00:24
@smithki smithki requested a review from Dizigen February 22, 2020 00:24
Dizigen
Dizigen reviewed Feb 24, 2020
View reviewed changes
src/modules/auth/index.ts Outdated Show resolved Hide resolved
Dizigen
Dizigen reviewed Feb 24, 2020
View reviewed changes
src/types/auth-module.ts Outdated Show resolved Hide resolved
Dizigen
Dizigen approved these changes Feb 24, 2020
View reviewed changes
Copy link
Contributor

@Dizigen Dizigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just NITs
🐑

@smithki smithki merged commit 64c5bf2 into master Feb 24, 2020
@FYJen FYJen deleted the smithki_boilerplate branch April 17, 2020 19:06
@FYJen FYJen mentioned this pull request May 1, 2020
Merged
4 tasks
@smithki
Copy link
Contributor Author

smithki commented Oct 22, 2020

🚀 PR was released in @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], [email protected] 🚀

@smithki smithki added the released This issue/pull request has been released. label Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dizigen Dizigen Dizigen approved these changes

Assignees
No one assigned
Labels
released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
2 participants
@smithki @Dizigen