Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open source prep #46

Merged
merged 2 commits into from
Apr 16, 2020
Merged

Open source prep #46

merged 2 commits into from
Apr 16, 2020

Conversation

smithki
Copy link
Contributor

@smithki smithki commented Apr 16, 2020

Fixes #43
Fixes #44

@smithki smithki requested a review from FYJen April 16, 2020 17:20
@smithki smithki self-assigned this Apr 16, 2020
Copy link
Contributor

@FYJen FYJen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicee! Loves those templates! LGTM.


## Opening a Pull Request

1. Update the **`Upcoming Changes`** section of [`CHANGELOG.md`](./CHANGELOG.md) with your fixes, changes, or additions. A maintainer will label your changes with a version number and release date once they are published.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice, get them to do it.

@smithki smithki merged commit 88de014 into master Apr 16, 2020
@FYJen FYJen deleted the smithki_open_source_prep branch April 17, 2020 19:07
@smithki
Copy link
Contributor Author

smithki commented Oct 22, 2020

@smithki smithki added the released This issue/pull request has been released. label Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OSS Prep] Issue/PR Templates [OSS Prep] README Updates
2 participants