Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds react-native-inappbrowser-reborn as peer to Bare RN OAuth #432

Merged
merged 4 commits into from
Jan 18, 2023

Conversation

Ariflo
Copy link
Contributor

@Ariflo Ariflo commented Jan 13, 2023

πŸ“¦ Pull Request

Adds react-native-inappbrowser-reborn as a peer dependency to our Bare RN OAuth Extension.

βœ… Fixed Issues

n/a

🚨 Test instructions

n/a

⚠️ Don't forget to add a semver label!

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.

@Ariflo Ariflo added patch Increment the patch version when merged documentation Changes only affect the documentation labels Jan 13, 2023
@Ariflo Ariflo self-assigned this Jan 13, 2023
Ethella
Ethella previously approved these changes Jan 16, 2023
Copy link
Member

@Ethella Ethella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we need to update the graphCMS as well?

@Ariflo
Copy link
Contributor Author

Ariflo commented Jan 18, 2023

LGTM. Do we need to update the graphCMS as well?

Yep, already done :)

@Ariflo Ariflo merged commit 653760e into master Jan 18, 2023
@Ariflo Ariflo deleted the ariflo-sc-68703-add-peer-to-bare-oauth branch January 18, 2023 01:05
@magiclabsFE
Copy link

@magiclabsFE magiclabsFE added the released This issue/pull request has been released. label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes only affect the documentation patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants