Replaces WebView View wrapper with SafeAreaView #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #67874: MC Expo SDK. |
Ariflo
added
major
Ariflo
force-pushed
the
ariflo-sc-67874-mc-rn-expo
branch
from
abd24dd
to
c069405
Compare
Ethella
approved these changes
Jan 18, 2023
|
🚀 PR was released in |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Pull Request
Replaces the View wrapping the RN SDK package
WebViewwith a SafeAreaView to prevent UI overlap with device hardware.✅ Fixed Issues
🚨 Test instructions
Using either the bare or expo sample apps, install either
@magic-sdk/[email protected]or@magic-sdk/[email protected]canary versions. Update the login method to utilize Magic's SMS login feature.Screenshots
Before
After
patch: Bug Fix?minor: New Feature?major: Breaking Change?skip-release: It's unnecessary to publish this change.