Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task: Decouple expo web browser from RN ext oauth #366

Closed
wants to merge 1 commit into from

Conversation

rcorrie
Copy link

@rcorrie rcorrie commented Oct 5, 2022

πŸ“¦ Pull Request

Removes expo-web-browser dependency and replaces it with react-native-inappbrowser-reborn.

This allows both expo and bare RN apps to use this extension.

βœ… Fixed Issues

#313

🚨 Test instructions

Install this extension and add react-native-inappbrowser-reborn to your project (yarn add react-native-inappbrowser).

No changes are needed for OAuth login Implementation.

@Ariflo
Copy link
Contributor

Ariflo commented Nov 10, 2022

Hi πŸ‘‹ @rcorrie, Thanks we'll check this solution, and validate if it's feasible and secured in our mobile architecture.

@Ariflo Ariflo self-assigned this Nov 14, 2022
@Ariflo
Copy link
Contributor

Ariflo commented Jan 3, 2023

Integrated in #412 Thanks again for the tip @rcorrie!

@Ariflo Ariflo closed this Jan 3, 2023
@rcorrie
Copy link
Author

rcorrie commented Jan 30, 2023

@Ariflo no problem.

It might be a good idea to make a mention of the react-native-inappbrowser-reborn dependency somewhere in the react-native-expo-oauth docs.

@Ariflo
Copy link
Contributor

Ariflo commented Jan 31, 2023

@Ariflo no problem.

It might be a good idea to make a mention of the react-native-inappbrowser-reborn dependency somewhere in the react-native-expo-oauth docs.

Thanks again @rcorrie I'll see about adding a README to those packages. FWIW, the info on these extension are available on our site. πŸ‘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants