Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update conflux constructor #328

Merged
merged 4 commits into from
Jun 29, 2022
Merged

Conversation

hcote
Copy link
Contributor

@hcote hcote commented Jun 28, 2022

πŸ“¦ Pull Request

[Provide a general summary of the pull request here.]

Update the constructor to just have the developer pass in the rpc url and networkId

βœ… Fixed Issues

  • [List any fixed issues here like: Fixes #XXXX]

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.

@hcote hcote requested a review from adenekan41 June 28, 2022 18:12
@adenekan41 adenekan41 added the patch Increment the patch version when merged label Jun 28, 2022
@adenekan41 adenekan41 merged commit 0532e09 into master Jun 29, 2022
@adenekan41 adenekan41 deleted the hcote-update-conflux-constructor branch June 29, 2022 17:03
@magiclabsFE
Copy link

πŸš€ PR was released in @magic-ext/[email protected] πŸš€

@magiclabsFE magiclabsFE added the released This issue/pull request has been released. label Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants