Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move crypto-js to devDependencies to fix bundling error #242

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

hcote
Copy link
Contributor

@hcote hcote commented Nov 10, 2021

πŸ“¦ Pull Request

[Provide a general summary of the pull request here.]

This fixes the error (below) users on Next.js v12 would run into when starting their app.

Cannot find module '/.../node_modules/crypto-js/sha256' imported from /.../node_modules/@magic-ext/oauth/dist/modern/index.mjs
Did you mean to import crypto-js/sha256.js?`

βœ… Fixed Issues

  • [List any fixed issues here like: Fixes #XXXX]

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.

@hcote hcote requested a review from smithki November 10, 2021 14:38
@hcote hcote added the patch Increment the patch version when merged label Nov 10, 2021
@hcote hcote self-assigned this Nov 10, 2021
@hcote hcote merged commit aea1207 into master Nov 10, 2021
@hcote hcote deleted the hcote-oauth-cryptojs branch November 10, 2021 16:28
@smithki
Copy link
Contributor

smithki commented Nov 10, 2021

πŸš€ PR was released in @magic-ext/[email protected], @magic-sdk/[email protected] πŸš€

@smithki smithki added the released This issue/pull request has been released. label Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants