Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change 'externals' and 'global' condition in magic-sdk > CDN build #219

Merged
merged 2 commits into from
Sep 23, 2021
Merged

Change 'externals' and 'global' condition in magic-sdk > CDN build #219

merged 2 commits into from
Sep 23, 2021

Conversation

smithki
Copy link
Contributor

@smithki smithki commented Sep 23, 2021

Fixes an issue where OAuthExtension was incompatible with Magic SDK via CDN.

@smithki smithki added the patch Increment the patch version when merged label Sep 23, 2021
@smithki smithki merged commit c098986 into master Sep 23, 2021
@smithki smithki deleted the fix/oauth-broken-ctor-from-cdn branch September 23, 2021 01:23
@smithki
Copy link
Contributor Author

smithki commented Sep 23, 2021

🚀 PR was released in @magic-ext/[email protected], @magic-sdk/[email protected], [email protected] 🚀

@smithki smithki added the released This issue/pull request has been released. label Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@smithki