Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v6.0.0 #208

Merged
merged 12 commits into from
Sep 14, 2021
Merged

v6.0.0 #208

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
608c423
Re-factor build scripts to TypeScript (#202)
smithki Sep 10, 2021
3f58e7f
Fix ENV variable interpolations
smithki Sep 10, 2021
4b296f4
Force publish
smithki Sep 10, 2021
890ca55
Remove temporary change (#205)
smithki Sep 10, 2021
4ba48c0
Add '--force-publish' flag to 'lerna version' command
smithki Sep 10, 2021
33ab878
Apply forcePublish to 'auto'
smithki Sep 10, 2021
ec3976a
Log environment in one place during build
smithki Sep 10, 2021
1339a15
Trigger publish on 'magic-sdk' and '@magic-sdk/react-native'
smithki Sep 13, 2021
b0fae38
Remove comments used to trigger prerelease
smithki Sep 13, 2021
008a93e
Fix SemVer issues
smithki Sep 14, 2021
d9f73f8
Ignore 'semver' wrapper from test coverage
smithki Sep 14, 2021
3b5621f
Target 'web'
smithki Sep 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix ENV variable interpolations
  • Loading branch information
@smithki
smithki committed Sep 10, 2021
commit 3f58e7f39a217990945fc38c8b8ba14b51ae32c0
7 changes: 6 additions & 1 deletion scripts/utils/microbundle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ export async function microbundle(
external?: string;
} = {},
) {
console.log(
Object.entries(environment)
.map(([key, value]) => `${key}=${value}`)
.join(','),
);
if (options.output) {
/* eslint-disable prettier/prettier */
const args = [
Expand All @@ -26,7 +31,7 @@ export async function microbundle(
'--sourcemap', options.sourcemap ? 'true' : 'false',
options.external && '--external', options.external,
'--output', options.output,
'--define', Object.entries(environment).map(([key, value]) => `${key}=${value}`).join(','),
'--define', Object.entries(environment).map(([key, value]) => `process.env.${key}=${value}`).join(','),
options.name && '--name', options.name,
].filter(Boolean);
/* eslint-enable prettier/prettier */
Expand Down